bharathv commented on pull request #3535: URL: https://github.com/apache/hbase/pull/3535#issuecomment-891975851
> there already are multiple places where RIT info can be found: the main /master-status page and the rits.jsp page. I don't think it's that confusing what the differences between the different RIT info sources are; the /master-status gives an overview of the RIT, the rits.jsp gives more details in a human-friendly format, and the /rit servlet displays the metrics we want as JSON. there are indeed overlaps between these places, but each has its own purpose that is independent of the other ones. we may choose to display different info in the JSON than on the rits.jsp page (I asked for feedback in this JIRA comment about whether we should consider displaying only RITs over threshold in the JSON, or consider grouping by server name or state in the JSON I'm not convinced by the explanation. I can see how /master-status has a summary in the footer and is a bit different from the other pages but it is usually a common pattern to do something like /rits?type=html /rits?type=json /rits?type=txt etc and all are served by the backing page (especially when they are serving the same information presented in different ways). Not a big deal though, don't want to block the progress here. I'm ok if @apurtell has already +1ed the patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
