[
https://issues.apache.org/jira/browse/HBASE-26158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17392604#comment-17392604
]
Duo Zhang commented on HBASE-26158:
-----------------------------------
I do not think we should shade curator, still I do not see why HBase should
take care of zookeeper, if you say HBase is a platform, what about Hadoop? It
also uses zookeeper and HBase is even built on it which means it is more like a
platform than HBase, so why not rely on Hadoop to provide a zookeeper mini
cluster? Just because it does not do this in the past so it is not its duty?
Technically on the curator version, it has different versions for zookeeper
3.4.x and 3.5.x. It has already considered the compatibility issue, and also
shaded a bunch of dependencies. This is its duty, to make end users easy to use
zookeeper. I do not think on this topic HBase can do better than curator.
And on your current code base, I do not think it is a strong argument. I also
have lots of code depend on the old HBTU, I also need to change them. If you
think it is really a pain, just copy the mini zk cluster code into your own
code base and use it. This is what we have done in HBase many times, copy code
from Hadoop and use it by our own. The HBase metrics and HBase http module are
both started by copying code from Hadoop.
And on the last ‘dog fooding’, technically, we just wrap the HBTU and provide a
simpler interface to end users, so I do not think we break the rule, as we just
want to hide the internal things which should not be exposed to end users.
Thanks.
> MiniZooKeeperCluster should not be IA.Public
> --------------------------------------------
>
> Key: HBASE-26158
> URL: https://issues.apache.org/jira/browse/HBASE-26158
> Project: HBase
> Issue Type: Sub-task
> Components: API, test
> Reporter: Duo Zhang
> Priority: Major
>
> End users do not need to test HBase when zookeeper is broken. And if users
> want to start only a zookeeper cluster, they can just use curator-test, so I
> do not think we should expose this class as IA.Public.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
