bbeaudreault edited a comment on pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#issuecomment-894486861
@joshelser @clarax This is ready for another look. To summarize the changes:
- All of the interface changes have been combined into the new commit I just
added. I'll squash everything into 1 commit once we are done here.
- New class `BalanceRequest` (public/evolving), with 2 public factory
methods, and 1 public builder method.
- Create the BalancerRequest with either `BalanceRequest#execute()` or
`BalancerRequest#dryRun()`
- Once you have a BalancerRequest, you can optionally enable the old force
mode with `request#ignoreRegionsInTransition()`. I thought it would be good to
clarify what force means here, whereas a boolean is rather opaque.
- As a result, both normal and dryRun can be modified with
ignoreRegionsInTransition. This actually seems reasonable, and simplifies some
things.
- Similarly, I updated the hbase shell to have a single balance command.
Previously you could execute the balance command with a `"force"` argument, now
you can also specify a `"dry_run"` argument. You can also combine them, like
with the BalanceRequest. I added a 'ignore_rit' option as replacement for
'force' in the future.
- Both changes have also been applied to the RSGroup balance command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
