petersomogyi commented on a change in pull request #3567:
URL: https://github.com/apache/hbase/pull/3567#discussion_r685018258
##########
File path: dev-support/hbase-personality.sh
##########
@@ -148,7 +148,7 @@ function personality_modules
# If we have HADOOP_PROFILE specified and we're on branch-2.x, pass along
# the hadoop.profile system property. Ensures that Hadoop2 and Hadoop3
# logic is not both activated within Maven.
- if [[ -n "${HADOOP_PROFILE}" ]] && [[ "${PATCH_BRANCH}" =~ branch-2* ]] ;
then
+ if [[ -n "${HADOOP_PROFILE}" ]] && [[ "${PATCH_BRANCH}" = branch-2* ]] ; then
Review comment:
This way it won't match with `branch-2`.
Until we reach branch-20 this whole script will be replaced multiple times.
:)
```
PATCH_BRANCH=branch-2; if [[ "${PATCH_BRANCH}" = branch-2\.* ]]; then echo
"true"; else echo "false"; fi
false
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
