sunhelly commented on a change in pull request #3553:
URL: https://github.com/apache/hbase/pull/3553#discussion_r686655581
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/RegionScannerImpl.java
##########
@@ -768,7 +768,7 @@ public synchronized boolean reseek(byte[] row) throws
IOException {
}
@Override
- public void shipped() throws IOException {
+ public synchronized void shipped() throws IOException {
Review comment:
Hi, @saintstack , @Apache9 , actually we didn't find any clue of the
concurrently ship() and close() in RPC handlers, but there are some when
compaction.
@Apache9 do you mean the scanner lease may help in this problem? One RPC
handler gets a cached scanner and removes the lease, till encounters ex or
ship() completes in shipped-callback will add the scanner lease back. The other
RPC handlers should wait the lease exits, or else will throw ex.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
