[ 
https://issues.apache.org/jira/browse/HBASE-26175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17397834#comment-17397834
 ] 

Pankaj Kumar commented on HBASE-26175:
--------------------------------------

But OtherExcpetions category metric will provide only quantitve information not 
the exact execption, we should debug log as well. 

> MetricsHBaseServer should record all kinds of Exceptions
> --------------------------------------------------------
>
>                 Key: HBASE-26175
>                 URL: https://issues.apache.org/jira/browse/HBASE-26175
>             Project: HBase
>          Issue Type: Improvement
>          Components: metrics
>            Reporter: Xiaolin Ha
>            Priority: Major
>         Attachments: RequestTooBigException.png
>
>
> We can define a kind of Exception such as OtherExcpetions to record 
> exceptions doesn't in the following kinds of exceptions. Only debug those 
> exceptions by LOG.debug("Unknown exception type", throwable); is not helpful 
> to find errors.
> {code:java}
> if (throwable != null) {
>   if (throwable instanceof OutOfOrderScannerNextException) {
>     source.outOfOrderException();
>   } else if (throwable instanceof RegionTooBusyException) {
>     source.tooBusyException();
>   } else if (throwable instanceof UnknownScannerException) {
>     source.unknownScannerException();
>   } else if (throwable instanceof ScannerResetException) {
>     source.scannerResetException();
>   } else if (throwable instanceof RegionMovedException) {
>     source.movedRegionException();
>   } else if (throwable instanceof NotServingRegionException) {
>     source.notServingRegionException();
>   } else if (throwable instanceof FailedSanityCheckException) {
>     source.failedSanityException();
>   } else if (throwable instanceof MultiActionResultTooLarge) {
>     source.multiActionTooLargeException();
>   } else if (throwable instanceof CallQueueTooBigException) {
>     source.callQueueTooBigException();
>   } else if (throwable instanceof QuotaExceededException) {
>     source.quotaExceededException();
>   } else if (throwable instanceof RpcThrottlingException) {
>     source.rpcThrottlingException();
>   } else if (LOG.isDebugEnabled()) {
>     LOG.debug("Unknown exception type", throwable);
>   }
> }
> {code}
> !RequestTooBigException.png|width=787,height=336!
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to