sunhelly commented on a change in pull request #3489:
URL: https://github.com/apache/hbase/pull/3489#discussion_r687732620
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/monitoring/MonitoredRPCHandlerImpl.java
##########
@@ -53,11 +53,20 @@ public MonitoredRPCHandlerImpl() {
@Override
public synchronized MonitoredRPCHandlerImpl clone() {
- return (MonitoredRPCHandlerImpl) super.clone();
+ MonitoredRPCHandlerImpl clone = (MonitoredRPCHandlerImpl) super.clone();
Review comment:
Hi, @saintstack , in addition to the call info map, I also add a boolean
variant to mark if the MonitoredRPCHandlerImpl is a cloned snapshot of the
handler level MonitoredRPCHandlerImpl. So when the UI requests to display the
call info map after clone the MonitoredRPCHandlerImpl, every request will has
its own snapshot of the MonitoredRPCHandlerImpl according to the request time.
And the non-snapshot MonitoredRPCHandlerImpl can generate its own call info map
which independent with all the snapshots. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
