Apache9 commented on a change in pull request #3574:
URL: https://github.com/apache/hbase/pull/3574#discussion_r687752070
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/SplitTableRegionProcedure.java
##########
@@ -648,9 +656,11 @@ public void createDaughterRegions(final MasterProcedureEnv
env) throws IOExcepti
// there's files to split. It then fires up everything, waits for
// completion and finally checks for any exception
//
- // Note: splitStoreFiles creates daughter region dirs under the parent
splits dir
- // Nothing to unroll here if failure -- re-run createSplitsDir will
- // clean this up.
+ // Note: From HBASE-26187, splitStoreFiles now creates daughter region
dirs straight under the
Review comment:
The comment is incorrect now? We do not rely on CatalogJanitor to clean
up the partial regions. We need to clean in rollback.
I think we should just recreate the whole region directly when we call this
method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
