rda3mon commented on a change in pull request #3359:
URL: https://github.com/apache/hbase/pull/3359#discussion_r689984154
##########
File path:
hbase-backup/src/main/java/org/apache/hadoop/hbase/backup/impl/BackupManager.java
##########
@@ -514,24 +513,6 @@ public void addIncrementalBackupTableSet(Set<TableName>
tables) throws IOExcepti
systemTable.addIncrementalBackupTableSet(tables,
backupInfo.getBackupRootDir());
}
- /**
- * Saves list of WAL files after incremental backup operation. These files
will be stored until
- * TTL expiration and are used by Backup Log Cleaner plug-in to determine
which WAL files can be
- * safely purged.
- */
- public void recordWALFiles(List<String> files) throws IOException {
- systemTable.addWALFiles(files, backupInfo.getBackupId(),
backupInfo.getBackupRootDir());
Review comment:
@saintstack Sorry, I missed to reply on this one.
There is more cleanup possible, but not everything can be removed. Do you
think It can be merged to `hbase:meta`? Or is there a recommendation on what
should be in `hbase:meta` and what shouldn't?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
