shahrs87 commented on a change in pull request #3591:
URL: https://github.com/apache/hbase/pull/3591#discussion_r691241668
##########
File path:
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java
##########
@@ -736,6 +740,40 @@ private static void printUsage(final String errorMsg) {
System.err.println(" $ hbase " +
"org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication" +
" --starttime=1265875194289 --endtime=1265878794289 5 TestTable ");
+ System.err.println();
+ System.err.println(" To verify the data in TestTable between the cluster
runs VerifyReplication and cluster-b");
+ System.err.println(" Assume quorum address for cluster-b is
cluster-b-1.example.com,cluster-b-2.example.com,cluster-b-3.example.com:2181:/cluster-b");
+ System.err.println(
+ " $ hbase
org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication \\\n" +
+ "
cluster-b-1.example.com,cluster-b-2.example.com,cluster-b-3.example.com:2181:/cluster-b
\\\n" +
+ " TestTable");
+ System.err.println();
+ System.err.println(" To verify the data in TestTable between the secured
cluster runs VerifyReplication and insecure cluster-b");
+ System.err.println(
+ " $ hbase
org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication \\\n" +
+ " -D verifyrep.peer.hbase.security.authentication=simple \\\n" +
Review comment:
Do we expect a space between D and
verifyrep.peer.hbase.security.authentication ?
##########
File path:
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java
##########
@@ -755,7 +793,8 @@ public int run(String[] args) throws Exception {
* @throws Exception When running the job fails.
*/
public static void main(String[] args) throws Exception {
- int res = ToolRunner.run(HBaseConfiguration.create(), new
VerifyReplication(), args);
- System.exit(res);
+// int res = ToolRunner.run(HBaseConfiguration.create(), new
VerifyReplication(), args);
Review comment:
Forgot to uncomment ?
##########
File path:
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/replication/TestVerifyReplicationSecureClusterCredentials.java
##########
@@ -0,0 +1,166 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hbase.replication;
+
+import static org.junit.Assert.assertEquals;
+import java.io.File;
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Collection;
+import java.util.function.Supplier;
+import org.apache.hadoop.conf.Configuration;
+import org.apache.hadoop.hbase.HBaseClassTestRule;
+import org.apache.hadoop.hbase.HBaseTestingUtil;
+import org.apache.hadoop.hbase.client.Admin;
+import org.apache.hadoop.hbase.coprocessor.CoprocessorHost;
+import org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication;
+import org.apache.hadoop.hbase.security.HBaseKerberosUtils;
+import org.apache.hadoop.hbase.security.access.AccessController;
+import org.apache.hadoop.hbase.security.access.SecureTestUtil;
+import org.apache.hadoop.hbase.security.token.AuthenticationTokenIdentifier;
+import org.apache.hadoop.hbase.security.token.TokenProvider;
+import org.apache.hadoop.hbase.security.visibility.VisibilityTestUtil;
+import org.apache.hadoop.hbase.testclassification.LargeTests;
+import org.apache.hadoop.hbase.testclassification.ReplicationTests;
+import org.apache.hadoop.hbase.zookeeper.ZKClusterId;
+import org.apache.hadoop.hbase.zookeeper.ZKConfig;
+import org.apache.hadoop.io.Text;
+import org.apache.hadoop.mapreduce.Job;
+import org.apache.hadoop.minikdc.MiniKdc;
+import org.apache.hadoop.security.Credentials;
+import org.apache.hadoop.security.UserGroupInformation;
+import org.apache.hadoop.security.token.Token;
+import org.apache.hadoop.security.token.TokenIdentifier;
+import org.junit.AfterClass;
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+import org.junit.runners.Parameterized.Parameter;
+import org.junit.runners.Parameterized.Parameters;
+
+@Category({ ReplicationTests.class, LargeTests.class })
+@RunWith(Parameterized.class)
+public class TestVerifyReplicationSecureClusterCredentials {
+ @ClassRule
+ public static final HBaseClassTestRule CLASS_RULE =
+
HBaseClassTestRule.forClass(TestVerifyReplicationSecureClusterCredentials.class);
+
+ private static MiniKdc KDC;
+ private static final HBaseTestingUtil UTIL1 = new HBaseTestingUtil();
Review comment:
nit: add a comment that UTIL1 is secure cluster and UTIL2 is non-secure
cluster.
##########
File path:
hbase-mapreduce/src/main/java/org/apache/hadoop/hbase/mapreduce/replication/VerifyReplication.java
##########
@@ -736,6 +740,40 @@ private static void printUsage(final String errorMsg) {
System.err.println(" $ hbase " +
"org.apache.hadoop.hbase.mapreduce.replication.VerifyReplication" +
" --starttime=1265875194289 --endtime=1265878794289 5 TestTable ");
+ System.err.println();
+ System.err.println(" To verify the data in TestTable between the cluster
runs VerifyReplication and cluster-b");
Review comment:
nice work to add examples on how to run VerifyReplication between non
secure and secure environment. It is very helpful.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
