Apache9 commented on a change in pull request #3580:
URL: https://github.com/apache/hbase/pull/3580#discussion_r692962036
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/AbstractServer.java
##########
@@ -431,4 +435,18 @@ public FileSystem getFileSystem() {
protected abstract AbstractRpcServices getRpcService();
protected abstract String getProcessName();
+
+ public ServerType getServerType(){
+ String processName = getProcessName();
+ if(processName.equals(MASTER)){
Review comment:
nits: format?
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionCoprocessorEnvironment.java
##########
@@ -130,4 +131,13 @@
* @return the RawCellBuilder
*/
RawCellBuilder getCellBuilder();
+
+ /**
+ * Provide server type to let users know the current context, it is on
region server or compaction
+ * server or replication server, then user could choose different
implementations.
+ * 1. through rpc call: {@link #getConnection()}
Review comment:
The comment is a bit confusing if users do not know our previous
discussion. Better describe like this:
"Provide server type to let users know the current context, it is on region
server or compaction server or replication server, then users could choose
different implementations. For example, on compaction server, you can not get
the region instance, so if you want to get something from a region, maybe you
should go with getConnection(), to communicate with the actual region instance
through rpc. But if you are on region server, then you can just use getRegion
or getOnlineRegions to get the region instance directly."
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/ServerType.java
##########
@@ -0,0 +1,32 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hbase;
+
+import org.apache.yetus.audience.InterfaceAudience;
+
+/**
+ * Enum describing Server Type
+ */
[email protected]
Review comment:
LimitedPrivate("CP")?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
