bharathv commented on a change in pull request #3613: URL: https://github.com/apache/hbase/pull/3613#discussion_r694464233
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/client/ConnectionRegistryEndpoint.java ########## @@ -0,0 +1,56 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.client; + +import java.util.List; +import java.util.Optional; +import org.apache.hadoop.hbase.HRegionLocation; +import org.apache.hadoop.hbase.ServerName; +import org.apache.yetus.audience.InterfaceAudience; + +/** + * Define the necessary method for carrying {@code ClientMetaService}. + */ [email protected] +public interface ConnectionRegistryEndpoint { Review comment: I agree that we should land this (thanks for your other patch btw). All I'm saying is perhaps we could do this refactor _without creating another new interface ConnectionRegistryEndpoint that looks exactly like ConnectionRegistry?_ (like I mentioned in my first comment, pasting again below). This seems simpler than your patch, right, you can use 'this' instance as the registry object in both HMaster and HRegionServer, don't have to construct something explicit? or did I miss something? ``` public interface ServerConnectionRegistry extends ConnectionRegistry {} HMaster implements ServerConnectionRegistry { <Implement master based registry server side> } HRegionServer implements ServerConnectionRegistry { <Implement RegionServerRegistry server side here> } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
