jojochuang commented on a change in pull request #3596:
URL: https://github.com/apache/hbase/pull/3596#discussion_r695386109



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java
##########
@@ -244,7 +285,6 @@ public long getSize() {
 
   /**
    * Sets the region coprocessor env.
-   * @param coprocessorHost

Review comment:
       unrelated change, and this parameter isn't removed from the method.

##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java
##########
@@ -306,16 +344,13 @@ ReaderContext createReaderContext(boolean doDropBehind, 
long readahead, ReaderTy
         // Intercept the exception so can insert more info about the 
Reference; otherwise
         // exception just complains about some random file -- operator doesn't 
realize it
         // other end of a Reference
-        FileNotFoundException newFnfe = new FileNotFoundException(toString());
-        newFnfe.initCause(fnfe);
-        throw newFnfe;
+        throw decorateFileNotFoundException(fnfe);
       }
-      status = fs.getFileStatus(referencePath);
     } else {
       in = new FSDataInputStreamWrapper(fs, this.getPath(), doDropBehind, 
readahead);
-      status = fs.getFileStatus(initialPath);
     }
-    long length = status.getLen();
+    getFileStatus();

Review comment:
       remove this line since it looks redundant?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to