Apache9 commented on a change in pull request #3606:
URL: https://github.com/apache/hbase/pull/3606#discussion_r695588291
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##########
@@ -825,6 +829,20 @@ private void createRSGroupTable() throws IOException {
}
public boolean isOnline() {
Review comment:
I guess the intention here is we will not come back to offline mode
after online?
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##########
@@ -661,12 +663,14 @@ private synchronized void flushConfig(Map<String,
RSGroupInfo> newGroupMap) thro
return;
}
+ // Make changes visible
Review comment:
Why this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
