Apache-HBase commented on pull request #3612:
URL: https://github.com/apache/hbase/pull/3612#issuecomment-905469917


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 27s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 53s |  master passed  |
   | +1 :green_heart: |  compile  |   4m 40s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m 55s |  master passed  |
   | +1 :green_heart: |  spotbugs  |   3m 40s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 13s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 35s |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m 37s |  the patch passed  |
   | -0 :warning: |  javac  |   3m 10s |  hbase-server generated 1 new + 192 
unchanged - 1 fixed = 193 total (was 193)  |
   | -0 :warning: |  checkstyle  |   1m  8s |  hbase-server: The patch 
generated 27 new + 264 unchanged - 7 fixed = 291 total (was 271)  |
   | -0 :warning: |  checkstyle  |   0m 17s |  hbase-testing-util: The patch 
generated 1 new + 171 unchanged - 1 fixed = 172 total (was 172)  |
   | -0 :warning: |  whitespace  |   0m  0s |  The patch has 1 line(s) that end 
in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer 
https://git-scm.com/docs/git-apply  |
   | +1 :green_heart: |  hadoopcheck  |  21m  3s |  Patch does not cause any 
errors with Hadoop 3.1.2 3.2.1 3.3.0.  |
   | -1 :x: |  spotbugs  |   2m 23s |  hbase-server generated 3 new + 0 
unchanged - 0 fixed = 3 total (was 0)  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 37s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  60m 23s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:hbase-server |
   |  |  instanceof will always return true for all non-null values in 
org.apache.hadoop.hbase.HBaseRpcServicesBase.onConfigurationChange(Configuration),
 since all org.apache.hadoop.hbase.ipc.RpcServer are instances of 
org.apache.hadoop.hbase.conf.ConfigurationObserver  At 
HBaseRpcServicesBase.java:for all non-null values in 
org.apache.hadoop.hbase.HBaseRpcServicesBase.onConfigurationChange(Configuration),
 since all org.apache.hadoop.hbase.ipc.RpcServer are instances of 
org.apache.hadoop.hbase.conf.ConfigurationObserver  At 
HBaseRpcServicesBase.java:[line 239] |
   |  |  Call to org.apache.hadoop.hbase.ServerName.equals(Thread) in 
org.apache.hadoop.hbase.master.MasterRpcServices.lambda$clearDeadServers$4(Procedure)
  At MasterRpcServices.java: At MasterRpcServices.java:[line 2350] |
   |  |  masterless isn't initialized in 
org.apache.hadoop.hbase.regionserver.HRegionServer.canCreateBaseZNode() when 
invoked from constructor for superclass  At HRegionServer.java:when invoked 
from constructor for superclass  At HRegionServer.java:[line 570] |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3612/2/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3612 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
checkstyle compile |
   | uname | Linux 67700b676193 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 137c7dcd3d |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | javac | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3612/2/artifact/yetus-general-check/output/diff-compile-javac-hbase-server.txt
 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3612/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-server.txt
 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3612/2/artifact/yetus-general-check/output/diff-checkstyle-hbase-testing-util.txt
 |
   | whitespace | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3612/2/artifact/yetus-general-check/output/whitespace-eol.txt
 |
   | spotbugs | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3612/2/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html
 |
   | Max. process+thread count | 96 (vs. ulimit of 30000) |
   | modules | C: hbase-client hbase-server hbase-testing-util U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3612/2/console
 |
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to