apurtell commented on a change in pull request #3611:
URL: https://github.com/apache/hbase/pull/3611#discussion_r696026828
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -3776,14 +3776,16 @@ private long
doMiniBatchMutation(BatchOperationInProgress<?> batchOp) throws IOE
success = true;
return addedSize;
+ } catch (Throwable t) {
+ // If wal sync fails, then abort the Region server
+ if (!walSyncSuccess) {
+ rsServices.abort("Wal sync failed", t);
Review comment:
Agreed. How about "WAL sync failed, aborting to preserve WAL as source
of truth".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
