caroliney14 commented on a change in pull request #3606:
URL: https://github.com/apache/hbase/pull/3606#discussion_r696215404
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupInfoManagerImpl.java
##########
@@ -825,6 +829,20 @@ private void createRSGroupTable() throws IOException {
}
public boolean isOnline() {
Review comment:
I guess that was the original intention, but it seems
misleading/strange. We have encountered errors in prod resulting from trying to
flush to `hbase:rsgroup` when the table became unavailable after the initial
check and set to "online" -- in that case, we should go the offline path,
right? (Albeit this was in HBase 1 prod, so I'm not 100% sure if HBase 2+
hasn't fixed this -- from my understanding of the code, it hasn't?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
