Apache9 commented on a change in pull request #3627:
URL: https://github.com/apache/hbase/pull/3627#discussion_r696709741



##########
File path: 
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestSplitWALManager.java
##########
@@ -233,11 +234,20 @@ private void splitLogsTestHelper(HBaseTestingUtility 
testUtil) throws Exception
     ProcedureTestingUtility.submitAndWait(masterPE, procedures.get(0));
     Assert.assertEquals(0, splitWALManager.getWALsToSplit(testServer, 
false).size());
 
+    // Validate the old WAL file archive dir

Review comment:
       This is not part of the PR in HBASE-24632, and I checked the code for 
branch-2.4+, all of them do not contain these tests code. Should we also add 
these tests code to branch-2.4+?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to