Apache9 commented on a change in pull request #3646:
URL: https://github.com/apache/hbase/pull/3646#discussion_r699920065
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/compactions/ExploringCompactionPolicy.java
##########
@@ -120,10 +119,26 @@ public ExploringCompactionPolicy(final Configuration conf,
}
LOG.debug("Exploring compaction algorithm has selected {} files of size
{} starting at " +
"candidate #{} after considering {} permutations with {} in ratio",
bestSelection.size(),
- bestSize, bestSize, opts, optsInRatio);
+ bestSize, bestStart, opts, optsInRatio);
return new ArrayList<>(bestSelection);
}
+ /**
+ * Force select files in the candidates list to compact, from the head to
+ * the index that the accumulation length larger the max compaction size
+ */
+ public List<HStoreFile> forceSelectCompactFiles(final List<HStoreFile>
candidates, int maxFiles,
Review comment:
Mind explaining a bit about the change? The word 'force' seems does not
match the implementation of this method, it is just a simple size limited
compaction selection algorithm?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
