Apache9 commented on pull request #3656: URL: https://github.com/apache/hbase/pull/3656#issuecomment-914300760
> Overall, looks good. Have some minor remarks. > > Additionally, would it be a good idea to provide a tool that allows for setting the the migration tracker on sets of tables/cfs, for the scenarios where user doesn't want to enable it globally? Maybe good to go on a separate jira. Maybe we should not allow users to set this StoreFileTracker manually, it should be an intermediate state. The global StoreFileTracker configuration can only effect the newly created tables, and it does not make sense to use MigrationStoreFileTracker for a new table right? And when we want to change the StoreFileTracker implementation for an existing table, we will have two ModifyTableProcedures, first is to change the StoreFileTracker to MigrationStoreFileTracker, and the second is to change the StoreFileTracker to the final StoreFileTracker implementation. Not sure if this is easy to implement, as users could change the TableDescriptor as they want and then call a modifyTable, we need to find out the above case by analyzing the configrations from TableDescriptor. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
