Apache9 commented on pull request #3666: URL: https://github.com/apache/hbase/pull/3666#issuecomment-915694391
> Actually, now got bit confused by "persisting store engine configuration". I thought StoreFileTracker impl config would be interchangeable with StoreEngine, and we really don't want to mess with different StoreFileTracker impl being used by master and RSes operations, so we define table of CF descriptors as a global point. > > Are you thinking we should actually put the StoreEngine impl config here, and then, each StoreEngine impl would be responsible to configure its StoreFileTracker impl? Yes, I was thinking we should store the StoreEngine config as a whole. For example, if we use StripeCompaction in the past but later we change the default config to DateTieredCompaction, should we switch all the tables' config? At least for me, I do not think so. But anyway, changing stripe to date tiered will not cause data loss, only impact performance, so could be a separated issue, and let;s discuss more. Let's change the title to narrow down the scope to store file tracker only. And I think we'd beter add a method in StoreFileTracker, like `void persistConfiguration(TableDescriptorBuilder builder);` To store all the necessary configurations to the TableDescriptor. For example, for MigrationStoreFileTracker, we need to store the src and dst store file tracker implementation as well. WDYT? @wchevreuil Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
