taklwu commented on a change in pull request #92:
URL:
https://github.com/apache/hbase-operator-tools/pull/92#discussion_r705690436
##########
File path: hbase-hbck2/src/main/java/org/apache/hbase/hbck1/HBaseFsck.java
##########
@@ -2168,13 +2169,18 @@ public void loadHdfsRegionDirs() throws IOException,
InterruptedException {
// List all tables from HDFS
List<FileStatus> tableDirs = Lists.newArrayList();
- List<Path> paths = FSUtils.getTableDirs(fs, rootDir);
- for (Path path : paths) {
- TableName tableName = CommonFSUtils.getTableName(path);
- if ((!checkMetaOnly && isTableIncluded(tableName)) ||
- tableName.equals(TableName.META_TABLE_NAME)) {
- tableDirs.add(fs.getFileStatus(path));
+ if (!checkMetaOnly) {
+ for (Path tableDir : this.tableDirs) {
+ try {
+ fs.getFileStatus(tableDir);
+ } catch (IOException ioe) {
+ LOG.warn("Failed to get Table directory for included table: {}",
+ CommonFSUtils.getTableName(tableDir), ioe);
+ }
Review comment:
let me try to clarify and confirm, before this change if any give table
name of a table directory does not exist, will hbck continue to run ?
but I see here , we have a `LOG.warn` instead of throwing out the IOE to the
driver, doesn't it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
