joshelser commented on pull request #3663: URL: https://github.com/apache/hbase/pull/3663#issuecomment-916549124
Sorry for the belated reply. @bbeaudreault [my ask](https://github.com/apache/hbase/pull/3630#pullrequestreview-741167367) was to move BalanceResponse$Builder to be private, not BalanceRequest$Builder to be private. Users _are_ expected to be able to use BalancerRequest, as this is on `Admin#balance(BalanceRequest)`. https://github.com/apache/hbase/blob/a15e94a47f06ae665a0c213d092761431e907eac/hbase-client/src/main/java/org/apache/hadoop/hbase/client/Admin.java#L847 My point was that the Master is the only thing which should be _creating_ BalanceResponse objects, thus end users don't need to know about the BalanceResponse$Builder class. Because the constructors on BalanceRequest are private, users must use the Builder class. | Object | Client Visibility | |--------|----------------| |`BalanceRequest` | Public | |`BalanceRequest$Builder` | Public | |`BalanceResponse` | Public | |`BalanceResponse$Builder` | Private| Please correct me if I'm wrong. I think we want to revert the change to BalancerRequest$Builder and apply it to BalancerRespons$Builder instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
