Apache9 commented on a change in pull request #3685:
URL: https://github.com/apache/hbase/pull/3685#discussion_r709920887
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/MergeTableRegionsProcedure.java
##########
@@ -612,9 +610,7 @@ private void createMergedRegion(final MasterProcedureEnv
env) throws IOException
List<Path> mergedFiles = new ArrayList<>();
for (ColumnFamilyDescriptor hcd : htd.getColumnFamilies()) {
String family = hcd.getNameAsString();
- Configuration trackerConfig =
-
StoreFileTrackerFactory.mergeConfigurations(env.getMasterConfiguration(), htd,
hcd);
- StoreFileTracker tracker = StoreFileTrackerFactory.create(trackerConfig,
family, regionFs);
+ StoreFileTracker tracker =
StoreFileTrackerFactory.create(env.getMasterConfiguration(),htd, hcd, regionFs);
Review comment:
We should call mergeConfiguations in the create method but seemed I
missed it. Thank you for pointing out. Let me fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
