richardantal commented on a change in pull request #3688: URL: https://github.com/apache/hbase/pull/3688#discussion_r711108865
########## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMaxResultsPerColumnFamily.java ########## @@ -0,0 +1,300 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.regionserver; + +import static org.junit.Assert.assertEquals; +import org.apache.hadoop.conf.Configuration; +import org.apache.hadoop.hbase.HBaseClassTestRule; +import org.apache.hadoop.hbase.HBaseTestingUtil; +import org.apache.hadoop.hbase.HConstants; +import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.client.Admin; +import org.apache.hadoop.hbase.client.ColumnFamilyDescriptorBuilder; +import org.apache.hadoop.hbase.client.Durability; +import org.apache.hadoop.hbase.client.Put; +import org.apache.hadoop.hbase.client.Result; +import org.apache.hadoop.hbase.client.ResultScanner; +import org.apache.hadoop.hbase.client.Scan; +import org.apache.hadoop.hbase.client.Table; +import org.apache.hadoop.hbase.client.TableDescriptor; +import org.apache.hadoop.hbase.client.TableDescriptorBuilder; +import org.apache.hadoop.hbase.testclassification.MediumTests; +import org.apache.hadoop.hbase.testclassification.RestTests; +import org.apache.hadoop.hbase.util.Bytes; +import org.junit.AfterClass; +import org.junit.BeforeClass; +import org.junit.ClassRule; +import org.junit.Test; +import org.junit.experimental.categories.Category; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +@Category({RestTests.class, MediumTests.class}) +public class TestMaxResultsPerColumnFamily { + + @ClassRule + public static final HBaseClassTestRule CLASS_RULE = + HBaseClassTestRule.forClass(TestMaxResultsPerColumnFamily.class); + + private static final Logger LOG = LoggerFactory.getLogger( + TestMaxResultsPerColumnFamily.class); + + private static final byte [][] FAMILIES = { + Bytes.toBytes("1"), Bytes.toBytes("2") + }; + + private static final byte [][] VALUES = { + Bytes.toBytes("testValueOne"), Bytes.toBytes("testValueTwo") + }; + + private static final HBaseTestingUtil hbaseTestingUtility = new HBaseTestingUtil(); + + public static byte[] toByteArray(String s) { + return Bytes.toBytes(s); + } + + @BeforeClass + public static void setUpBeforeClass() throws Exception { + hbaseTestingUtility.startMiniCluster(3); + } + + @AfterClass + public static void tearDownAfterClass() throws Exception { + hbaseTestingUtility.shutdownMiniCluster(); + } + + @Test + public void tesSetMaxResultsPerColumnFamily() throws Exception { + Admin admin = hbaseTestingUtility.getAdmin(); + TableName tableName = TableName.valueOf("TestScannersWithFilters1"); + if (!admin.tableExists(tableName)) { + ColumnFamilyDescriptorBuilder cfBuilder0 = + ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[0]); + ColumnFamilyDescriptorBuilder cfBuilder1 = + ColumnFamilyDescriptorBuilder.newBuilder(FAMILIES[1]); + + TableDescriptor tableDescriptor = + TableDescriptorBuilder.newBuilder(tableName).setColumnFamily(cfBuilder0.build()) + .setColumnFamily(cfBuilder1.build()).build(); + admin.createTable(tableDescriptor); + Table table = hbaseTestingUtility.getConnection().getTable(tableName); + + for(int i = 0; i<20000; i++) { + byte [] ROW = toByteArray("" + i); + Put p = new Put(ROW); + p.setDurability(Durability.SKIP_WAL); + + int rows = 4; + if (i % 12 == 5 || i % 17 == 3) { Review comment: We don't need that. I just wanted to create data where the number of columns are not the same for every row. Thought it makes the data more realistic and it helped me to reproduce the issue in a test. Note that testSetMaxResultsPerColumnFamilySimpleBig also reproduced the issue without that magic. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
