nyl3532016 commented on a change in pull request #3677:
URL: https://github.com/apache/hbase/pull/3677#discussion_r712874180
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -1947,6 +1947,9 @@ public boolean shouldPerformMajorCompaction() throws
IOException {
if (!this.areWritesEnabled()) {
return Optional.empty();
}
+ if (this.getCoprocessorHost() != null) {
Review comment:
The original permission check in `preCompact` will check both rpc and
non rpc compactions, If we move the check to `requestCompactionInternal` we
can check both rpc and non rpc compactions also. And If we enable Compaction
offload `preCompact` will happen on compactionServer, premission check will not
work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
