mymeiyi commented on a change in pull request #3671:
URL: https://github.com/apache/hbase/pull/3671#discussion_r713542337



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -1962,6 +1963,11 @@ public boolean waitForFlushes(long timeout) {
     }
   }
 
+  @Override
+  public Configuration getReadOnlyConfiguration() {

Review comment:
       I think ReadOnlyConfiguration may be better. But I checked the code, the 
ReadOnlyConfiguration is only used in `CoprocessorEnvironment` and it use 
`Configuration getConfiguration()`, so here I use `Configuration` in the same 
way.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to