Apache9 commented on a change in pull request #3696:
URL: https://github.com/apache/hbase/pull/3696#discussion_r714559564
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/ConnectionImplementation.java
##########
@@ -462,24 +461,30 @@ public Admin getAdmin() throws IOException {
@Override
public Hbck getHbck() throws IOException {
- return getHbck(get(registry.getActiveMaster()));
+ ServerName masterServer = get(registry.getActiveMaster());
Review comment:
Why not move this line into the trace scope?
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/HTable.java
##########
@@ -393,45 +396,53 @@ protected Result rpcCall() throws Exception {
@Override
public Result[] get(List<Get> gets) throws IOException {
- if (gets.size() == 1) {
- return new Result[]{get(gets.get(0))};
- }
- try {
- Object[] r1 = new Object[gets.size()];
- batch((List<? extends Row>)gets, r1, readRpcTimeoutMs);
- // Translate.
- Result [] results = new Result[r1.length];
- int i = 0;
- for (Object obj: r1) {
- // Batch ensures if there is a failure we get an exception instead
- results[i++] = (Result)obj;
+ return TraceUtil.trace(() -> {
Review comment:
We do not need to use traceWithIOException here? Strange...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
