shahrs87 commented on pull request #3667:
URL: https://github.com/apache/hbase/pull/3667#issuecomment-926589188


   Attached 2 new screenshots in HBASE-21521. Attaching here also.
   
![hbase-21521-revised-1](https://user-images.githubusercontent.com/5529085/134674337-2f905fb5-5124-44cb-8313-f3bd19115d8e.png)
   
![hbase-21521-revised-2](https://user-images.githubusercontent.com/5529085/134674340-f86f9d23-da81-4cd9-a374-333bea644743.png)
   
   This now uses the `MonitoredTask` that we already have and removed many of 
the classes that I added as a part of 1st review process.
   The only thing I find little bit redundant is number of status it creates 
while waiting for RS to become online.
   Every WAIT_ON_REGIONSERVERS_TIMEOUT seconds (which defaults to 4.5 seconds), 
it will create a new status with updated message. I like the way it tells the 
operator that how many RS it was waiting for to become online.
   
   @joshelser  @apurtell  please review again. Thank you !


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to