Apache9 commented on a change in pull request #3660:
URL: https://github.com/apache/hbase/pull/3660#discussion_r717667508
##########
File path:
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
##########
@@ -617,4 +617,14 @@ private void roundRobinAssignment(BalancerClusterState
cluster, List<RegionInfo>
public void onConfigurationChange(Configuration conf) {
loadConf(conf);
}
+
+ @Override
+ public void reloadConfiguration() {
+ LOG.info("Reloading balancer configs");
+ // We clone and reload the clone because the original conf may be used in
other
+ // non-balancer contexts. We only want to reload configs for the balancer.
+ Configuration conf = new Configuration(getConf());
Review comment:
I think it is fine to just reload the balancer's config, the concern is
about the place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
