[ 
https://issues.apache.org/jira/browse/HBASE-26251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17422134#comment-17422134
 ] 

Hudson commented on HBASE-26251:
--------------------------------

Results for branch master
        [build #400 on 
builds.a.o|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/400/]:
 (/) *{color:green}+1 overall{color}*
----
details (if available):

(/) {color:green}+1 general checks{color}
-- For more information [see general 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/400/General_20Nightly_20Build_20Report/]






(/) {color:green}+1 jdk8 hadoop3 checks{color}
-- For more information [see jdk8 (hadoop3) 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/400/JDK8_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 jdk11 hadoop3 checks{color}
-- For more information [see jdk11 
report|https://ci-hadoop.apache.org/job/HBase/job/HBase%20Nightly/job/master/400/JDK11_20Nightly_20Build_20Report_20_28Hadoop3_29/]


(/) {color:green}+1 source release artifact{color}
-- See build output for details.


(/) {color:green}+1 client integration test{color}


> StochasticLoadBalancer metrics should update even if balancer doesn't run
> -------------------------------------------------------------------------
>
>                 Key: HBASE-26251
>                 URL: https://issues.apache.org/jira/browse/HBASE-26251
>             Project: HBase
>          Issue Type: Improvement
>          Components: Balancer
>            Reporter: Bryan Beaudreault
>            Assignee: Zhuoyue Huang
>            Priority: Minor
>             Fix For: 2.5.0, 3.0.0-alpha-2
>
>
> Currently we only update StochasticLoadBalancerMetrics at the very end of a 
> balancer run, once a plan has been found. In fact, we update the metrics 
> based on that plan even if we don't end up executing the plan, which seems 
> incorrect. 
> Regardless of whether the balancer decides to run or not, cluster costs are 
> changing all the time. Since we don't update these metrics any other time, 
> operators miss out on important information about the balance of their 
> cluster over time. 
> I briefly looked into it and it would be relatively trivial to add another 
> call to updateStochasticCosts at the beginning of the balanceTable method, 
> before we determine if the cluster is in need of balancing. This would be an 
> improvement but would still miss cases where the balancer is disabled or 
> unable to run due to regions in transition, etc.
> It would be good if we could make it so updateStochasticCosts get called 
> periodically regardless of whether the balancer is enabled or can run.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to