pankaj72981 commented on a change in pull request #3712:
URL: https://github.com/apache/hbase/pull/3712#discussion_r721614194
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/DirScanPool.java
##########
@@ -39,21 +39,28 @@
private final ThreadPoolExecutor pool;
private int cleanerLatch;
private boolean reconfigNotification;
+ private final String cleanerPoolConfig;
+ private final String cleanerPoolConfigDefault;
+ private final String name;
- public DirScanPool(Configuration conf) {
- String poolSize = conf.get(CleanerChore.CHORE_POOL_SIZE,
CleanerChore.DEFAULT_CHORE_POOL_SIZE);
+ private DirScanPool(Configuration conf, String cleanerPoolConfig, String
cleanerPoolConfigDefault,
Review comment:
+1 for "DirScanPool can have a private Enum Type (for
ArchivedHFilesCleaner, OldLogsCleaner)"
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
##########
@@ -64,6 +64,8 @@
*/
public static final String CHORE_POOL_SIZE =
"hbase.cleaner.scan.dir.concurrent.size";
static final String DEFAULT_CHORE_POOL_SIZE = "0.25";
+ public static final String LOG_CLEANER_CHORE_SIZE =
"hbase.log.cleaner.scan.dir.concurrent.size";
Review comment:
I think, pool of 1 thread (by default) is for scanning and cleaning the
old WALs. And pool with 25% of #cores (by default) is for archived store files.
+1 adding code level comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
