wchevreuil commented on pull request #3721: URL: https://github.com/apache/hbase/pull/3721#issuecomment-934457567
> A possible way is to pass in a null StoreContext, and the implementation class should check whether the StoreContext is null, if so, then it should construct itself in the 'persist store tracker configurations' mode. That could be an option, despite looking a bit hacky. Alternatively, we could ensure init() is called prior to start adding/loading/replacing store files. WDYT? > I think the latter one will be cleaner but not sure if we can force the implementation class has a static method at compile time. That was exactly my first idea, but the lack of enforcement of static methods on implementations is a problem, IMO, which led me to the alternative solution. > But at least, we could introduce a UT for checking this. I believe the UT I had added would catch this problem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
