clarax commented on a change in pull request #3710:
URL: https://github.com/apache/hbase/pull/3710#discussion_r723708702
##########
File path:
hbase-balancer/src/main/java/org/apache/hadoop/hbase/master/balancer/StochasticLoadBalancer.java
##########
@@ -598,8 +605,8 @@ private String functionCost() {
builder.append(", ");
double cost = c.cost();
builder.append("imbalance=" + cost);
- if (cost < minCostNeedBalance) {
- builder.append(", balanced");
+ if (cost >= minCostNeedBalance) {
+ builder.append(", need balance");
Review comment:
It is better to callout the factors that need more weight than the
factors that don't.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
