[ https://issues.apache.org/jira/browse/HBASE-6109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285821#comment-13285821 ]
Zhihong Yu commented on HBASE-6109: ----------------------------------- {code} + // A number of lock we want to easily support. It's not a maximum. {code} 'A number' -> 'The number' {code} + // We need an atomic counter to manage the number of people using the lock and free it when + // it's equals to zero. {code} 'number of people' -> 'number of users' 'it's equals to zero.' -> 'it's equal to zero.' {code} + static class RegionLock<K> extends ReentrantLock { {code} The outer class is generic. The inner class shouldn't mention Region. > Improve RIT performances during assignment on large clusters > ------------------------------------------------------------ > > Key: HBASE-6109 > URL: https://issues.apache.org/jira/browse/HBASE-6109 > Project: HBase > Issue Type: Improvement > Components: master > Affects Versions: 0.96.0 > Reporter: nkeywal > Assignee: nkeywal > Priority: Minor > Fix For: 0.96.0 > > Attachments: 6109.v19.patch, 6109.v7.patch > > > The main points in this patch are: > - lowering the number of copy of the RIT list > - lowering the number of synchronization > - synchronizing on a region rather than on everything > It also contains: > - some fixes around the RIT notification: the list was sometimes modified > without a corresponding 'notify'. > - some tests flakiness correction, actually unrelated to this patch. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira