wchevreuil commented on a change in pull request #3721:
URL: https://github.com/apache/hbase/pull/3721#discussion_r726129081
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/storefiletracker/MigrationStoreFileTracker.java
##########
@@ -89,14 +90,16 @@ void set(List<StoreFileInfo> files) {
}
@Override
- public void persistConfiguration(TableDescriptorBuilder builder) {
- super.persistConfiguration(builder);
- if (StringUtils.isEmpty(builder.getValue(SRC_IMPL))) {
+ public TableDescriptor updateWithTrackerConfigs(TableDescriptor descriptor) {
Review comment:
Right. Is it not worth having it here, case we need to call this from
elsewhere, other than table creation? I was planning to extend
MigrationStoreFileTracker for the snapshot issue I'm working on HBASE-26328, so
that I have a snapshot sft as source, and whatever is the SFT impl defined as
target. Ain't sure now if this method would be required from there, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
