GeorryHuang commented on pull request #3700: URL: https://github.com/apache/hbase/pull/3700#issuecomment-940519827
> In general I like the approach to introduce a chore for upgrading and also a new procedure for updating the procedure. > > But the problem here is the inheritance hierarchy of the procedures. We have a lot of states for ModifyTableProcedure, which are not needed for the upgrading procedure, and also, it will be safer if we do the check on whether we still need to update the descriptor in the procedure. > > So let me 'steal' part of your work here, to reimplement the migrating of rs group on master branch, and then do a rebase so you could make use of the code to implement this PR cleaner. > > WDYT? > > Thanks. I agree with you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
