wchevreuil commented on a change in pull request #3721:
URL: https://github.com/apache/hbase/pull/3721#discussion_r727866389
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/procedure/TestCreateTableProcedure.java
##########
@@ -105,6 +106,21 @@ public void testCreateWithTrackImpl() throws Exception {
assertEquals(trackerName, htd.getValue(TRACKER_IMPL));
}
+ @Test
+ public void testCreateWithFileBasedStoreTrackerImpl() throws Exception {
+ ProcedureExecutor<MasterProcedureEnv> procExec =
getMasterProcedureExecutor();
+
procExec.getEnvironment().getMasterConfiguration().set(StoreFileTrackerFactory.TRACKER_IMPL,
+ StoreFileTrackerFactory.Trackers.FILE.name());
Review comment:
Yes, just checked now and found out that this relies on a static
HBaseTestingUtil variable declared in the parent TestTableDDLProcedureBase
class, so any concurrent sub-classes instances of that could end up picking
that config.
I don't think this would be a problem for other tests, though, since none of
those are validating store file tracking work itself, and whatever is being
tested elsewhere shouldn't break because of this setting (if it does break some
other test, then it's probably a regression we are introducing here).
The only potential problem is if both this
testCreateWithFileBasedStoreTrackerImpl and testCreateWithTrackImpl test
methods run concurrently, but I don't think that happens for methods within the
same test class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
