ndimiduk commented on a change in pull request #3754:
URL: https://github.com/apache/hbase/pull/3754#discussion_r730022186
##########
File path: bin/hbase
##########
@@ -487,8 +487,16 @@ add_jdk11_deps_to_classpath() {
done
}
-enable_trace() {
- agent_jar=$(find lib/trace -type f -name "opentelemetry-javaagent-*")
+add_opentelemetry_agent() {
+ if ! agent_jar=$(find lib/trace -type f -name "opentelemetry-javaagent-*"
2>/dev/null); then
Review comment:
@taklwu I made the patch on a Mac and it works fine for me. Are you
running from a git checkout after `mvn install` or are you running from an
assembled binary tgz?
I don't think zsh should have anything to do with it because `bin/hbase`
declares a she-bang line of `#! /usr/bin/env bash`.
##########
File path: bin/hbase
##########
@@ -487,8 +487,16 @@ add_jdk11_deps_to_classpath() {
done
}
-enable_trace() {
- agent_jar=$(find lib/trace -type f -name "opentelemetry-javaagent-*")
+add_opentelemetry_agent() {
+ if ! agent_jar=$(find lib/trace -type f -name "opentelemetry-javaagent-*"
2>/dev/null); then
Review comment:
Right, `lib/trace` only exists after a `mvn assemble` invocation, so
your dev sandbox is precisely they type of environment I'm trying to support
with this change. No apology necessary, thank you for trying it out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
