[
https://issues.apache.org/jira/browse/HBASE-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13285979#comment-13285979
]
stack commented on HBASE-6087:
------------------------------
Why this change in a patch that adds a new module?
{code}
+# For releases, add hbase & webapps to CLASSPATH
+# Webapps must come first else it messes up Jetty
+if [ -d "$HBASE_HOME/hbase-webapps" ]; then
+ add_to_cp_if_exists "${HBASE_HOME}"
+fi
+#add if we are in a dev environment
+if [ -d "$HBASE_HOME/hbase-server/target/hbase-webapps" ]; then
+ add_to_cp_if_exists "${HBASE_HOME}/hbase-server/target"
+fi
{code}
Why is it being moved earlier?
Doesn't this get inherited from parent? "+
<version>0.95-SNAPSHOT</version>" (This is version of the new hbase-common
pom.xml).
This comment is wrong?
{code}
+ <!--
+ profile for building against Hadoop 0.23.0. Activate using:
+ mvn -Dhadoop.profile=23
+ -->
{code}
Thats good HBaseConfiguration comes up. HConstants too? That think is an ugly
anti-pattern. I'm fine w/ it going up but need to figure how to kill it.
I'm +1 on committing this. Good stuff Jesse. Is it ready to go you think?
> Add hbase-common module
> -----------------------
>
> Key: HBASE-6087
> URL: https://issues.apache.org/jira/browse/HBASE-6087
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 0.96.0
> Reporter: Jesse Yates
> Assignee: Jesse Yates
> Attachments: hbase-6087-v0.patch, hbase-6087-v1.patch
>
>
> Add an hbase-common module so common/utility classes can be pulled up out of
> hbase-server. This is _not_ the moving of classes, just the general project
> setup.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
