apurtell commented on a change in pull request #3730:
URL: https://github.com/apache/hbase/pull/3730#discussion_r732140690
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/HFileBlockDefaultDecodingContext.java
##########
@@ -87,8 +92,24 @@ public void prepareDecoding(int onDiskSizeWithoutHeader, int
uncompressedSizeWit
Compression.Algorithm compression = fileContext.getCompression();
if (compression != Compression.Algorithm.NONE) {
- Compression.decompress(blockBufferWithoutHeader, dataInputStream,
- uncompressedSizeWithoutHeader, compression);
+ Decompressor decompressor = null;
+ try {
+ decompressor = compression.getDecompressor();
+ // Some algorithms don't return decompressors and accept null as a
valid parameter for
+ // same when creating decompression streams. We can ignore these
cases wrt reinit.
+ if (decompressor != null && decompressor instanceof CanReinit) {
+ ((CanReinit)decompressor).reinit(conf);
+ }
+ try (InputStream is =
+ compression.createDecompressionStream(dataInputStream,
decompressor, 0)) {
+ BlockIOUtils.readFullyWithHeapBuffer(is, blockBufferWithoutHeader,
+ uncompressedSizeWithoutHeader);
+ }
+ } finally {
+ if (decompressor != null) {
+ compression.returnDecompressor(decompressor);
+ }
+ }
Review comment:
Sure, it is not being used, I think removal is a good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
