Apache9 commented on a change in pull request #3784:
URL: https://github.com/apache/hbase/pull/3784#discussion_r736109066
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/JVM.java
##########
@@ -60,6 +60,9 @@
private static final String JVMVersion = System.getProperty("java.version");
+ private static final Float JREVersion =
+ Float.parseFloat(System.getProperty("java.specification.version"));
Review comment:
OK. But maybe we'd better unify them to the same pattern? For example,
we check whether the returned property contains a dot, if so, we just parse the
last character as a int, otherwise parse the whole String. And for the field
name, better name it as JVM_RELEASE_VERSION or JVM_SPEC_VERSION? And also add
some comments to explain the meaning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
