frostruan commented on a change in pull request #3716:
URL: https://github.com/apache/hbase/pull/3716#discussion_r737773899
##########
File path: hbase-protocol-shaded/src/main/protobuf/server/region/Admin.proto
##########
@@ -277,6 +284,7 @@ message ExecuteProceduresRequest {
repeated OpenRegionRequest open_region = 1;
repeated CloseRegionRequest close_region = 2;
repeated RemoteProcedureRequest proc = 3;
+ repeated SnapshotRegionRequest snapshot_region = 4;
Review comment:
Thanks for your reply. @Apache9
I think we have three options to implement snapshot logic here.
**option a**. using a **RegionRemoteProcedure** to implement region related
operations, like open, close, snapshot and flush. That's my choice in the first
commit.
**option b**. using a **ServerRemoteProcedure** to snapshot regions (or just
a single region) in a remote server, like log splitting or claim replication
queue. That's my choice for snapshot verifying. I think this is what you
recommend.
**option c**. we introduce a new method snapshotRegion in **Admin.proto**
for RegionServerAdmin, and give it admin priority just like flush region and
log roll. for master, we just throw unsupported exception.
Sorry I misunderstood what you say "It can not be implemented as a
RemoteProcedure?". I thought you mean "we shouldn't using remote procedure to
implement this". so I changed from option a to option c.
Of course we can implement snapshot with ServerRemoteProcedure. Actually I
think it makes easier to snapshot regions because we don't need to modify
RSProcedureDispatcher to introduce a new kind of region operation. I will try
to fix this as soon as possible. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
