Apache-HBase commented on pull request #3800:
URL: https://github.com/apache/hbase/pull/3800#issuecomment-953933699


   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 34s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 30s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m 25s |  master passed  |
   | +1 :green_heart: |  compile  |   4m 16s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m 20s |  master passed  |
   | +1 :green_heart: |  spotbugs  |   2m 45s |  master passed  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 15s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m 16s |  the patch passed  |
   | +1 :green_heart: |  compile  |   4m 10s |  the patch passed  |
   | -0 :warning: |  javac  |   0m 31s |  hbase-asyncfs generated 8 new + 22 
unchanged - 7 fixed = 30 total (was 29)  |
   | -0 :warning: |  checkstyle  |   0m 13s |  hbase-asyncfs: The patch 
generated 1 new + 1 unchanged - 1 fixed = 2 total (was 2)  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace 
issues.  |
   | +1 :green_heart: |  hadoopcheck  |  22m  0s |  Patch does not cause any 
errors with Hadoop 3.1.2 3.2.1 3.3.0.  |
   | -1 :x: |  spotbugs  |   0m 51s |  hbase-asyncfs generated 2 new + 0 
unchanged - 0 fixed = 2 total (was 0)  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   0m 26s |  The patch does not generate 
ASF License warnings.  |
   |  |   |  59m  0s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:hbase-asyncfs |
   |  |  Nullcheck of excludeDatanodeManager at line 468 of value previously 
dereferenced in 
org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.createOutput(DistributedFileSystem,
 String, boolean, boolean, short, long, EventLoopGroup, Class, 
StreamSlowMonitor)  At FanOutOneBlockAsyncDFSOutputHelper.java:468 of value 
previously dereferenced in 
org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper.createOutput(DistributedFileSystem,
 String, boolean, boolean, short, long, EventLoopGroup, Class, 
StreamSlowMonitor)  At FanOutOneBlockAsyncDFSOutputHelper.java:[line 468] |
   |  |  Should 
org.apache.hadoop.hbase.io.asyncfs.monitor.StreamSlowMonitor$PacketAckData be a 
_static_ inner class?  At StreamSlowMonitor.java:inner class?  At 
StreamSlowMonitor.java:[lines 129-144] |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.41 ServerAPI=1.41 base: 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3800/3/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/3800 |
   | Optional Tests | dupname asflicense javac spotbugs hadoopcheck hbaseanti 
checkstyle compile |
   | uname | Linux 12ff38fd70c8 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 60254bc184 |
   | Default Java | AdoptOpenJDK-1.8.0_282-b08 |
   | javac | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3800/3/artifact/yetus-general-check/output/diff-compile-javac-hbase-asyncfs.txt
 |
   | checkstyle | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3800/3/artifact/yetus-general-check/output/diff-checkstyle-hbase-asyncfs.txt
 |
   | spotbugs | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3800/3/artifact/yetus-general-check/output/new-spotbugs-hbase-asyncfs.html
 |
   | Max. process+thread count | 96 (vs. ulimit of 30000) |
   | modules | C: hbase-asyncfs hbase-server U: . |
   | Console output | 
https://ci-hadoop.apache.org/job/HBase/job/HBase-PreCommit-GitHub-PR/job/PR-3800/3/console
 |
   | versions | git=2.17.1 maven=3.6.3 spotbugs=4.2.2 |
   | Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to