[
https://issues.apache.org/jira/browse/HBASE-26366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438834#comment-17438834
]
Nick Dimiduk commented on HBASE-26366:
--------------------------------------
There's an argument to be made for remove tracing from this part of the code.
These ZK operations are not in the critical path of user data queries, so I
think the odds of an operator having interest in this is low.
The counter argument is that when this gets stuck, having traces could be
really helpful. {{blockUntilBecomingActive}} is itself too long-lived to be the
root span, but maybe there's a point when is starts to take over ownership that
makes sense to be the start of a span, and one that we emit 100% of the time.
> ZK interaction during Master startup produces loads of root-less spans
> ----------------------------------------------------------------------
>
> Key: HBASE-26366
> URL: https://issues.apache.org/jira/browse/HBASE-26366
> Project: HBase
> Issue Type: Bug
> Components: tracing
> Affects Versions: 2.5.0, 3.0.0-alpha-2
> Reporter: Nick Dimiduk
> Priority: Major
> Attachments: image.png,
> regroup-spans-for-recoverablezookeeper.create.png
>
>
> Enable tracing with {{-Dotel.traces.sampler=always_on}} and launch the
> standalone master, check the trace store. We see lots of single-span traces,
> each a call to different {{RecoverableZooKeeper}} methods, like {{create}}
> and {{exists}}. Whatever master startup thread this is should define its own
> root span.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
