[
https://issues.apache.org/jira/browse/HBASE-26414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17438931#comment-17438931
]
Nick Dimiduk commented on HBASE-26414:
--------------------------------------
Guidance received from the [CNCF otel Slack
channel|https://cloud-native.slack.com/archives/C0150QF88FL/p1636051570159600]
suggests this is the correct approach.
{quote}
I think you should use the name and version of the library itself, if the
instrumentation is built-in to the library. If it’s an add-on module for the
library, then use the name/version of that module.
...
I think that’s great. It shouldn’t collide with any other instrumentation, and
clearly identifies it. Those are the 2 main criteria, so :thumbsup:
{quote}
> Tracing INSTRUMENTATION_NAME is incorrect
> -----------------------------------------
>
> Key: HBASE-26414
> URL: https://issues.apache.org/jira/browse/HBASE-26414
> Project: HBase
> Issue Type: Bug
> Components: tracing
> Affects Versions: 2.5.0, 3.0.0-alpha-2
> Reporter: Nick Dimiduk
> Priority: Blocker
>
> I believe the value we use for {{TraceUtil#INSTRUMENTATION_NAME}},
> {{"io.opentelemetry.contrib.hbase"}}, is incorrect. According to the java
> docs,
> {noformat}
> * @param instrumentationName The name of the instrumentation library, not
> the name of the
> * instrument*ed* library (e.g., "io.opentelemetry.contrib.mongodb").
> Must not be null.
> {noformat}
> This namespace appears to be reserved for implementations shipped by the otel
> project, found under
> https://github.com/open-telemetry/opentelemetry-java-instrumentation/tree/main/instrumentation
> I don't have a suggestion for a suitable name at this time. Will report back.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
