LALAYANG commented on pull request #3615: URL: https://github.com/apache/hbase/pull/3615#issuecomment-964157972
In test `org.apache.hadoop.hbase.monitoring.TestTaskMonitor.testDoNotPurgeRPCTask`, `TaskMonitor` is not created each time, so the pollution is not cleaned. There are 2 kinds of fixes: - Clean all tasks when the test ends. - Another solution is to create a new TaskMonitor each time to avoid pollution similar to the other tests (e.g., testTaskMonitorBasics, testTasksGetAbortedOnLeak) in TestTaskMonitor. Create a new TaskMonitor each time to avoid flaky tests. LALAYANG/hbase#1 Please let me know which fix you think is better. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
