taklwu commented on pull request #3823: URL: https://github.com/apache/hbase/pull/3823#issuecomment-964562435
https://github.com/apache/hbase/blob/8ce7b92ff540736c9ceefd86dd1d9f142454bb45/hbase-shell/src/main/ruby/shell/commands/trace.rb#L29 above line should reaplace HTrace to OpenTelemetry https://github.com/apache/hbase/blob/8ce7b92ff540736c9ceefd86dd1d9f142454bb45/hbase-shell/src/main/ruby/shell/commands/trace.rb#L33 [nit] I personally don't want the stop to return `false` if it's success, but I'm not sure if we should change the behavior -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
