bbeaudreault commented on a change in pull request #3803:
URL: https://github.com/apache/hbase/pull/3803#discussion_r748601997
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStoreFile.java
##########
@@ -362,6 +369,15 @@ private void open() throws IOException {
fileInfo.getHFileInfo().initMetaAndIndex(reader.getHFileReader());
}
this.initialReader = fileInfo.postStoreFileReaderOpen(context, cacheConf,
reader);
+
+ if (InputStreamBlockDistribution.isEnabled(fileInfo.getConf())) {
+ boolean useHBaseChecksum =
context.getInputStreamWrapper().shouldUseHBaseChecksum();
+ FSDataInputStream stream =
context.getInputStreamWrapper().getStream(useHBaseChecksum);
+ if (stream instanceof HdfsDataInputStream) {
Review comment:
We've started rolling this out to prod. During the rollout we realized
that this check does not cover FileLinks, which end up as a plain
FSDataInputStream wrapping a FileLinkInputStream which further wraps the real
underlying HdfsDataInputStream. That's a lot of wrappers, and I'll need to
unwrap them to appropriately derive HDFSBlockDistribution for FileLinks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
