wchevreuil commented on a change in pull request #3845:
URL: https://github.com/apache/hbase/pull/3845#discussion_r750496366
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterFileSystem.java
##########
@@ -110,28 +108,13 @@ public void testCheckTempDir() throws Exception {
// disable the table so that we can manipulate the files
UTIL.getAdmin().disableTable(tableName);
- final Path tableDir =
CommonFSUtils.getTableDir(masterFileSystem.getRootDir(), tableName);
final Path tempDir = masterFileSystem.getTempDir();
- final Path tempTableDir = CommonFSUtils.getTableDir(tempDir, tableName);
+ final Path tempNsDir = CommonFSUtils.getNamespaceDir(tempDir,
+ tableName.getNamespaceAsString());
final FileSystem fs = masterFileSystem.getFileSystem();
- // move the table to the temporary directory
- if (!fs.rename(tableDir, tempTableDir)) {
- fail();
- }
-
- masterFileSystem.checkTempDir(tempDir, UTIL.getConfiguration(), fs);
-
- // check if the temporary directory exists and is empty
- assertTrue(fs.exists(tempDir));
- assertEquals(0, fs.listStatus(tempDir).length);
-
- // check for the existence of the archive directory
- for (HRegion region : regions) {
- Path archiveDir =
HFileArchiveTestingUtil.getRegionArchiveDir(UTIL.getConfiguration(),
- region);
- assertTrue(fs.exists(archiveDir));
- }
+ // checks the temporary directory does not exist
+ assertFalse(fs.exists(tempNsDir));
Review comment:
We now make sure no temp dir was created for table namespace during the
CreateTableProcedure run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
